Skip to content

Add PAL Debug option to NTSC #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Mar 30, 2024
Merged

Add PAL Debug option to NTSC #206

merged 14 commits into from
Mar 30, 2024

Conversation

idlechild
Copy link
Collaborator

PAL Debug option is also persistent in SRAM, mainly because it was easier to code that way.
Also ported some improvements from IFB's HackROMBase branch.

I want to add tasdance support to moondance room strat, and then there is a request to improve charge timer. There's also a request to add HBJ trainer which I am ignoring (sorry!) There was a request to fix something about the menu shortcut; do we have a fix for that already?

Is there more we wanted in the next update? I feel like I'm forgetting about something.

@InsaneFirebat
Copy link
Collaborator

InsaneFirebat commented Mar 24, 2024

There was a request to fix something about the menu shortcut; do we have a fix for that already?

I didn't write anything at the time. You could move the menu shortcut check to the top, right before save/loadstate, in gamemode.asm. Or you could put this untested code at line 1714 of menu.asm. (or both?)

Edit: Added the branch to .exit
Edit2: Got around to testing this and it needed more work. Made a pull request to your fork idlechild#1

    ; disallow inputs that match the menu shortcut
    LDA [!DP_CtrlInput] : CMP.w #!sram_ctrl_menu : BEQ .store
    CMP !sram_ctrl_menu : BNE .store
    %sfxfail()
    ; write code to set cursor position to 0 (menu shortcut)
    LDA #$0000 : STA !ram_cm_stack_index : STA !ram_cm_ctrl_last_input
    BRA .exit

  .store
    ; Store controller input to SRAM

Also prioritize checking for the menu shortcut, instead of checking last
@idlechild
Copy link
Collaborator Author

Alright that's the last of the infohud modes that needed some improvements. Sheesh that shinetune bug in the last number has been out there for a while and ended up being simple to account for. I'm not sure it's perfect but it's definitely improved.

So it's just tasdance support. As soon as that's done (or I give up on it), then I think 2.6.1 will be ready to ship. Any objections?

@idlechild idlechild marked this pull request as ready for review March 30, 2024 01:08
@idlechild
Copy link
Collaborator Author

I'm going to test it a bit more in an hour, but it is otherwise ready for release. I'll likely release it later tonight.

@InsaneFirebat
Copy link
Collaborator

I haven't caught up with the last few commits yet but I'm good with it either way

@idlechild idlechild merged commit 9ccc603 into tewtal:master Mar 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants