-
Notifications
You must be signed in to change notification settings - Fork 20
Add PAL Debug option to NTSC #206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I didn't write anything at the time. You could move the menu shortcut check to the top, right before save/loadstate, in gamemode.asm. Or you could put this untested code at line 1714 of menu.asm. (or both?) Edit: Added the branch to .exit
|
Also prioritize checking for the menu shortcut, instead of checking last
Disallow shortcuts that match menu inputs
Alright that's the last of the infohud modes that needed some improvements. Sheesh that shinetune bug in the last number has been out there for a while and ended up being simple to account for. I'm not sure it's perfect but it's definitely improved. So it's just tasdance support. As soon as that's done (or I give up on it), then I think 2.6.1 will be ready to ship. Any objections? |
I'm going to test it a bit more in an hour, but it is otherwise ready for release. I'll likely release it later tonight. |
I haven't caught up with the last few commits yet but I'm good with it either way |
PAL Debug option is also persistent in SRAM, mainly because it was easier to code that way.
Also ported some improvements from IFB's HackROMBase branch.
I want to add tasdance support to moondance room strat, and then there is a request to improve charge timer. There's also a request to add HBJ trainer which I am ignoring (sorry!) There was a request to fix something about the menu shortcut; do we have a fix for that already?
Is there more we wanted in the next update? I feel like I'm forgetting about something.